Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry data initial implementation #51715

Merged
merged 8 commits into from
Feb 7, 2020
Merged

Telemetry data initial implementation #51715

merged 8 commits into from
Feb 7, 2020

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Jan 30, 2020 •
edited
Loading

This is a first iteration of telemetry data support for EQL. Main classes are in, test classes make sense at this point when the hooks will be available in EQL code. Also, same goes for the actual logic that increments the counters.

Part of #49630.

@astefan astefan requested review from costin and imotov January 31, 2020 08:52
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/EQL)

@astefan astefan marked this pull request as ready for review January 31, 2020 08:55
imotov
imotov reviewed Jan 31, 2020
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition! Added some comments.

x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/XPackSettings.java Outdated Show resolved Hide resolved
docs/reference/rest-api/info.asciidoc Show resolved Hide resolved
costin
costin approved these changes Feb 2, 2020
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

imotov
imotov reviewed Feb 4, 2020
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will fail in non-snapshot builds unless we do something with eql.enabled:true.

docs/reference/rest-api/info.asciidoc Show resolved Hide resolved
@astefan
Copy link
Contributor Author

astefan commented Feb 6, 2020

@elasticmachine run elasticsearch-ci/packaging-sample-matrix-windows

@astefan
Copy link
Contributor Author

astefan commented Feb 6, 2020

@elasticmachine update branch

@astefan astefan requested a review from imotov February 7, 2020 00:36
imotov
imotov approved these changes Feb 7, 2020
View reviewed changes
Copy link
Contributor

@imotov imotov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@astefan astefan merged commit f1d1cce into elastic:master Feb 7, 2020
@astefan astefan deleted the 49630_impl branch February 7, 2020 21:00
astefan added a commit to astefan/elasticsearch that referenced this pull request Feb 11, 2020
@astefan
Telemetry data initial implementation (elastic#51715)
7481976 
(cherry picked from commit f1d1cce)
@astefan astefan mentioned this pull request Feb 11, 2020
Merged
astefan added a commit that referenced this pull request Feb 11, 2020
@astefan
Telemetry data initial implementation (#51715) (#52175)
2f1631d 
(cherry picked from commit f1d1cce)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@imotov imotov imotov approved these changes

Assignees
No one assigned
Labels
:Analytics/EQL EQL querying >feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@astefan @elasticmachine @costin @imotov